Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Closed
Description
property
'stp_init
hasthis code:
if (Py_IS_TYPE(self, &PyProperty_Type)) { Py_XSETREF(self->prop_doc, prop_doc); } else { /* If this is a property subclass, put __doc__ in dict of the subclass instance instead, otherwise it gets shadowed by __doc__ in the class's dict. */ /*...*/ PyObject_SetAttr((PyObject *)self, &_Py_ID(__doc__), prop_doc); /*...*/ }
This assumes that subclasses ofproperty
have a__dict__
(or a__doc__
attribute settable by other means). That is the case when subclassed using theclass
statement, but might not be true using C.
A C-API reproducer is athttps://github.com/wjakob/inheritance_issue/blob/master/inheritance_issue.c
I don't see a good way to fix this. We could:
- document that subclasses need to set
Py_TPFLAGS_MANAGED_DICT
(or provide a__doc__
descriptor), or - ignore the
AttributeError
, unless__doc__
was set explicitly?