Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-98948: Remove obsolete readelf dependency#98949
Merged
vstinner merged 1 commit intopython:mainfromNov 3, 2022
Merged
Conversation
ContributorAuthor
serge-sans-paille commentedNov 1, 2022
cc@vstinner , because I know he's in love with autoconf. I didn't run a local autoreconf because my local version is different from the one used to generate previous version. Instead, I manually edited the |
26b6505 to033f5f0CompareMember
vstinner commentedNov 2, 2022
Can you try to add a NEWS entry in the Build category to document your change? Seehttps://devguide.python.org/ about blurb. |
Member
vstinner commentedNov 2, 2022
I added a commit to your branch: I ran "make regen-configure" which uses a container to get always the same version. |
e425077 to0fae64fCompareContributorAuthor
serge-sans-paille commentedNov 2, 2022
@vstinner : entry added & commits squashed. Thanks for the review! |
0fae64f tod69d8adCompareThis got introduced in commit5884449to determine if readline is already linked against curses or tinfo inthe setup.py, which is no longer present.
d69d8ad to0de323bCompareMember
vstinner commentedNov 3, 2022
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This got introduced in commit5884449 to determine if readline is already linked against curses or tinfo in the setup.py, which is no longer present.