Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Closed
Assignees
Description
Bug report
A few weeks ago, thetyping_extensions backport library received a bug report thattest_overload_on_compiled_functions(), a recently added test, failed when run on PyPy:python/typing_extensions#83. This is due to the fact thatbuiltins.sum() andbuiltins.print() are not compiled functions on PyPy.
The same test exists in the CPython test suite (the test was ported over totyping_extensions inpython/typing_extensions#73 after being added to the CPython test suite in#96479):
cpython/Lib/test/test_typing.py
Lines 4638 to 4650 inde69816
| deftest_overload_on_compiled_functions(self): | |
| withpatch("typing._overload_registry", | |
| defaultdict(lambda:defaultdict(dict))): | |
| # The registry starts out empty: | |
| self.assertEqual(typing._overload_registry, {}) | |
| # This should just not fail: | |
| overload(sum) | |
| overload(print) | |
| # No overloads are recorded (but, it still has a side-effect): | |
| self.assertEqual(typing.get_overloads(sum), []) | |
| self.assertEqual(typing.get_overloads(print), []) |
I think the test should probably be marked with the@test.support.cpython_only decorator in the CPython test suite.
(Cc.@sobolevn, who added the test.)