Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-98023: Change default child watcher toPidfdChildWatcher on supported systems#98024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bedevere-bot commentedOct 7, 2022
🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit2e26bf5 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
kumaraditya303 commentedOct 7, 2022
The unicode failure will be fixed by#98036 and is unrelated. |
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This LGTM, but...
I reviewed the child watcher architecture with@1st1 and we want to first do a refactoring on PidfdChildWatcher. Basically the current PidfdChildWatcher attaches itself to the event loop in the main thread, and if it is called from a loop in another thread it won't work. ThreadedChildWatcher doesn't have this problem.
HOWEVER, Yury has a simple refactoring of PidfdChildWatcher in mind that will solve this problem! It will make attach_loop() a no-op, and is_active() will always be True -- just as it is for the ThreadedChildWatcher.
So once Yury's change is merged, this can be merged. (We don't quite have a PR but there will be one soon, I promise.)
gvanrossum commentedOct 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
gvanrossum commentedOct 8, 2022
The docs failure is due to something that was accidentally merged, no point in updating and re-running all the tests. The Azure failure is due to the same thing. Still waiting forGH-94184 to go green and merge. |
* main:pythongh-68686: Retire eptag ptag scripts (python#98064)pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)pythongh-97822: Fix http.server documentation reference to test() function (python#98027)pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
* main: (5519 commits) Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009)pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)pythongh-68686: Retire eptag ptag scripts (python#98064)pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)pythongh-97822: Fix http.server documentation reference to test() function (python#98027)pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)pythongh-57179: Add note on symlinks for os.walk (python#94799)pythongh-94808: Fix regex on exotic platforms (python#98036)pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) ...
This is a backport from cpython 3.12https://docs.python.org/3/library/asyncio-policy.html> PidfdChildWatcher is a “Goldilocks” child watcher implementation. It doesn’t require signals or threads, doesn’t interfere with any processes launched outside the event loop, and scales linearly with the number of subprocesses launched by the event loop. The main disadvantage is that pidfds are specific to Linux, and only work on recent (5.3+) kernels.python/cpython#98024There are some additional fixes in cpython 3.12inpython/cpython#94184when there is no event loop running in the main threadbut this is not a problem we have
This is a backport from cpython 3.12https://docs.python.org/3/library/asyncio-policy.html> PidfdChildWatcher is a “Goldilocks” child watcher implementation. It doesn’t require signals or threads, doesn’t interfere with any processes launched outside the event loop, and scales linearly with the number of subprocesses launched by the event loop. The main disadvantage is that pidfds are specific to Linux, and only work on recent (5.3+) kernels.python/cpython#98024There are some additional fixes in cpython 3.12inpython/cpython#94184when there is no event loop running in the main threadbut this is not a problem we have
This is a backport from cpython 3.12https://docs.python.org/3/library/asyncio-policy.html> PidfdChildWatcher is a “Goldilocks” child watcher implementation. It doesn’t require signals or threads, doesn’t interfere with any processes launched outside the event loop, and scales linearly with the number of subprocesses launched by the event loop. The main disadvantage is that pidfds are specific to Linux, and only work on recent (5.3+) kernels.python/cpython#98024There are some additional fixes in cpython 3.12inpython/cpython#94184when there is no event loop running in the main threadbut this is not a problem we have
Uh oh!
There was an error while loading.Please reload this page.
PidfdChildWatcheron supported Linux versions #98023