Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-72719: Remove deprecatedasyncore andasynchat modules#96580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 7 commits intopython:mainfromsobolevn:issue-72719
Nov 8, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedSep 5, 2022•
edited
Loading

Several notes:

  1. I followed the same path assmtpd ingh-93243: Make smtpd private before porting its users #93246 It was suggested inRemove asyncore, asynchat and smtpd modules #72719 (comment) by@vstinner
  2. I've addedTODO items about completely removing these modules in the future

PEP:https://peps.python.org/pep-0594/

arhadthedev and hugovk reacted with thumbs up emoji
@sobolevnsobolevnforce-pushed theissue-72719 branch 2 times, most recently from92a5bab to97d7bc8CompareSeptember 5, 2022 14:29
@arhadthedev
Copy link
Member

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible inasyncore but not inasyncio as soon as possible.

@sobolevn
Copy link
MemberAuthor

Ping@pablogsal as release manager 🙂

@pablogsal
Copy link
Member

Ping@pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is@Yhg1s so he should probably also take a look

@sobolevnsobolevn added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelSep 25, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@sobolevn for commit99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelSep 25, 2022
@arhadthedev
Copy link
Member

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

…pzF3.rstCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@@ -0,0 +1,3 @@
Remove modules:mod:`asyncore` and:mod:`asynchat`, which were deprecated by:pep:`594`.

They are temporarily moved to:mod:`test.support` so some other tests that rely on them keep working.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, thank you for the review!

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please remove last references:

  • Doc/library/socketserver.rst
  • Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed fromgithub/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

@vstinner
Copy link
Member

When I removed the module last year (commit), I even renamed the asyncore module totest.support._asyncore. But I don't mind to call ittest.support.asyncore.

@giampaolo
Copy link
Contributor

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

sobolevn reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

Done, all three - removed!

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

sobolevn reacted with hooray emojisobolevn reacted with heart emoji
@vstinner
Copy link
Member

Merged, thanks. Let's see how it goes with Python 3.12.

@sobolevn
Copy link
MemberAuthor

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

@vstinner
Copy link
Member

SreekanthModupalli

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@hugovkhugovkhugovk left review comments

@vstinnervstinnervstinner approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@giampaologiampaoloAwaiting requested review from giampaologiampaolo is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

+2 more reviewers

@theLastOfCatstheLastOfCatstheLastOfCats left review comments

@SreekanthModupalliSreekanthModupalliSreekanthModupalli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sobolevn@arhadthedev@pablogsal@bedevere-bot@vstinner@giampaolo@JelleZijlstra@hugovk@theLastOfCats@SreekanthModupalli
[8]ページ先頭
©2009-2025 Movatter.jp