Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-95051: ensure that timeouts scheduled withasyncio.Timeout that have already expired are deliverered promptly#95109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 9 commits intopython:mainfromgraingert:asyncio-timeout-0-0
Jul 24, 2022

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commentedJul 21, 2022•
edited by bedevere-bot
Loading

carltongibson reacted with thumbs up emoji
@graingertgraingert changed the titlegh-95051: handle timeouts.timeout(0) and timeouts.timeout(-1)gh-95051: ensure that timeouts scheduled in the past withasyncio.Timeout are deliverered promptlyJul 21, 2022
@graingertgraingert changed the titlegh-95051: ensure that timeouts scheduled in the past withasyncio.Timeout are deliverered promptlygh-95051: ensure that timeouts scheduled withasyncio.Timeout that have already expired are deliverered promptlyJul 21, 2022
@graingertgraingert added the needs backport to 3.11only security fixes labelJul 21, 2022
@graingertgraingert marked this pull request as ready for reviewJuly 22, 2022 09:42
…xA9r.rstCo-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG, just a nit, and maybe now that we're testing this behavior, it should be noted in the docs?

graingertand others added2 commitsJuly 23, 2022 00:59
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@gvanrossumgvanrossum merged commit0c6f898 intopython:mainJul 24, 2022
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@graingert and@gvanrossum, I had trouble checking out the3.11 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 0c6f898005099be189ee65bcfda659f5fc13b802 3.11

@graingertgraingert deleted the asyncio-timeout-0-0 branchJuly 24, 2022 20:18
@gvanrossum
Copy link
Member

@graingert please backport manually and ask Pablo for a review.

graingert reacted with thumbs up emoji

@AlexWaygoodAlexWaygood added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsJul 24, 2022
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95216 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 24, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commentedJul 24, 2022•
edited
Loading

@graingert please backport manually and ask Pablo for a review.

When@miss-islington's message is "I had trouble checking out the 3.X branch" (as opposed to "I couldn't create the backport due to a merge conflict"), just removing and re-adding the label is usually enough to fix it :)

@graingertgraingert added the needs backport to 3.11only security fixes labelJul 24, 2022
@miss-islington
Copy link
Contributor

Thanks@graingert for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 24, 2022
… that have already expired are deliverered promptly (pythonGH-95109)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>(cherry picked from commit0c6f898)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@AlexWaygood
Copy link
Member

GH-95216 is a backport of this pull request to the3.11 branch.

@graingert, I already removed and re-added the label — this is the backport here

@AlexWaygoodAlexWaygood removed the needs backport to 3.11only security fixes labelJul 24, 2022
@graingert
Copy link
ContributorAuthor

argh I saw the email notification and had a stale copy of the PR page open

AlexWaygood reacted with laugh emoji

@AlexWaygood
Copy link
Member

argh I saw the email notification and had a stale copy of the PR page open

It's race conditions all the way down

@gvanrossum
Copy link
Member

Maybe one of you can make the bot more user friendly?

@graingert
Copy link
ContributorAuthor

It's race conditions all the way down

AlexWaygood reacted with laugh emoji

@AlexWaygood
Copy link
Member

Maybe one of you can make the bot more user friendly?

It's been on my to-do list for a while.....

ambv pushed a commit that referenced this pull requestJul 26, 2022
…have already expired are deliverered promptly (GH-95109) (GH-95216)Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>(cherry picked from commit0c6f898)Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

@gvanrossumgvanrossum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@graingert@miss-islington@gvanrossum@bedevere-bot@AlexWaygood@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp