Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94801: Use custom flags to check for headers and libs#94802

Merged
tiran merged 2 commits intopython:mainfrom
tiran:gh-94801-cflags
Jul 15, 2022
Merged

gh-94801: Use custom flags to check for headers and libs#94802
tiran merged 2 commits intopython:mainfrom
tiran:gh-94801-cflags

Conversation

@tiran
Copy link
Member

@tirantiran commentedJul 13, 2022•
edited by miss-islington
Loading

@tiran
Copy link
MemberAuthor

I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports.

@tirantiran marked this pull request as ready for reviewJuly 13, 2022 21:30
@tirantiran added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 14, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit7bb04f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 14, 2022
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! LGTM.

@tirantiran added 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelsJul 15, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

1 similar comment
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@tiran for commit1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJul 15, 2022
@tirantiran merged commit944ff8c intopython:mainJul 15, 2022
@miss-islington
Copy link
Contributor

Thanks@tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tirantiran deleted the gh-94801-cflags branchJuly 15, 2022 12:48
@miss-islington
Copy link
Contributor

Sorry,@tiran, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 944ff8c57c9e8ff5a5bd18925070ddb1504490ab 3.11

tiran added a commit to tiran/cpython that referenced this pull requestJul 15, 2022
…pythonGH-94802).(cherry picked from commit944ff8c)Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 15, 2022
@bedevere-bot
Copy link

GH-94881 is a backport of this pull request to the3.11 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

@tirantiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@miss-islington@erlend-aasland

Comments

[8]ページ先頭
©2009-2026 Movatter.jp