Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

makesetup can fail on macOS and uses wrong CFLAGS #94404

Closed
Labels
3.11only security fixes3.12only security fixesbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error
@tiran

Description

@tiran

Bug report

The scriptModules/makesetup has two issues

  1. It uses sedi command with multiple escapes newlines. The feature works fine in GNU sed but does not work correctly with macOS' BSD sed.@ned-deily found aworkaround for the problem. Ther command with an external replacement file works correctly on GNU and BSD sed.

  2. makesetup creates wrong compile rules for object files that end up in a shared library. The variables$(CCSHARED) $(PY_CFLAGS_NODIST) $(PY_CPPFLAGS) are missing some flags like address sanitizer. The script should create rules with$(PY_STDMODULE_CFLAGS) $(CCSHARED) instead.

  3. the order of cflags can break builds. For example macOS ARM64 builds arebroken because-I./Modules/_decimal/libmpdec comes after-I/opt/homebrew/include and the buildbot seems to come with an incompatible libmpdec header. Module-specific CFLAGs should come before Python CFLAGs. It is probably easier to move module CFLAGS beforePY_STDMODULE_CFLAGS. The homebrew flag comes fromPY_CPPFLAGS andCONFIGURE_CPPFLAGS.

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.11only security fixes3.12only security fixesbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp