Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-92547: Remove deprecated sqlite3 features#92548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 5 commits intomainfromsqlite-remove-deprecated-features
May 16, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 9, 2022•
edited
Loading

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com

Closes#92547

The following sqlite3 features were deprecated in 3.10, scheduled forremoval in 3.12:- sqlite3.OptimizedUnicode (gh-23163)- sqlite3.enable_shared_cache (gh-24008)Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

erlend-aasland reacted with thumbs up emoji
@erlend-aasland
Copy link
ContributorAuthor

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

FTR,nltk/nltk#3000 was just merged.

@JelleZijlstra
Copy link
Member

Feel free to merge!

erlend-aasland reacted with hooray emoji

@erlend-aaslanderlend-aasland merged commit00f22e8 intomainMay 16, 2022
@erlend-aaslanderlend-aasland deleted the sqlite-remove-deprecated-features branchMay 16, 2022 17:52
@erlend-aasland
Copy link
ContributorAuthor

Thanks for helping, Jelle and Victor!

@vstinner
Copy link
Member

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared:00f22e8

Would you mind to copy these information in What's New in Python 3.12?

@erlend-aasland
Copy link
ContributorAuthor

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared:00f22e8

Would you mind to copy these information in What's New in Python 3.12?

Yes, I'll amend What's New. Thanks for the heads-up!

@erlend-aasland
Copy link
ContributorAuthor

Would you mind to copy these information in What's New in Python 3.12?

Something like this?#93872

@vstinner
Copy link
Member

Something like this?#93872

That's very valuable, thanks.

erlend-aasland reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: remove features deprecated in 3.10

5 participants

@erlend-aasland@JelleZijlstra@vstinner@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp