Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-92120: The docstring of enum.Enum is invalid in reST#92122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tk0miya
Copy link
Contributor

@tk0miyatk0miya commentedMay 1, 2022•
edited by bedevere-bot
Loading

@AlexWaygoodAlexWaygood added stdlibPython modules in the Lib dir type-bugAn unexpected behavior, bug, or error labelsMay 1, 2022
@hugovk
Copy link
Member

Thank you Takeshi-san!

Are similar fixes needed in theEnumType class?

- attribute access::

- attribute access::

Please could you include a NEWS file?

https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python

@ethanfurman
Copy link
Member

I am more interested in the docstrings being usable bydoctest than being correct reStructured text. Have you verified thatdoctest correctly executes the docstrings with your changes applied?

@tk0miyatk0miyaforce-pushed thegh-92120/invalid_docstring_of_Enum branch 4 times, most recently from4b243fd toeb44f0bCompareMay 5, 2022 18:01
@tk0miya
Copy link
ContributorAuthor

Thank you for your reviews! I also fixed EnumTypes class.

Have you verified that doctest correctly executes the docstrings with your changes applied?

Yes. I confirmed it on my local. This change does not prevent the result of doctest. Of course, the number of cases are not changed. Additionally, doctest on GitHub Action is also passed.
refs:https://github.com/python/cpython/runs/6310616547?check_suite_focus=true_

@tk0miyatk0miyaforce-pushed thegh-92120/invalid_docstring_of_Enum branch fromeb44f0b tod95098eCompareMay 7, 2022 17:55
@netlify
Copy link

netlifybot commentedDec 7, 2022•
edited
Loading

✅ Deploy Preview forpython-cpython-preview canceled.

NameLink
🔨 Latest commit61c60b9
🔍 Latest deploy loghttps://app.netlify.com/sites/python-cpython-preview/deploys/6390cf790be2c70009088bad

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanfurmanethanfurmanethanfurman approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

Assignees

@ethanfurmanethanfurman

Labels
stdlibPython modules in the Lib dirtype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The docstring ofenum.Enum is invalid in reStructuredText since 3.11
6 participants
@tk0miya@hugovk@ethanfurman@AA-Turner@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp