Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
Correctly fold unknown-8bit originating from encoded words.#142517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The unknown-8bit trick was designed to deal with unknown bytes in anASCII message, and it works fine for that. However, I also tried toextend it to handle bytes that can't be decoded using the charsetspecified in an encoded word, and there it fails because there can beother non-ASCII characters that were *successfully* decoded. The fix issimple: do the unknown-8bit encoding using the utf-8 codec. This isespecially appropriate since anyone trying to do recovery on an unknownbyte string will probably attempt utf-8 first.
4ae90b4 to1bba134CompareMemberAuthor
bitdancer commentedDec 16, 2025
Does anyone want to review this, or shall I just merge it? |
1e17ccd intopython:main 48 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@bitdancer for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks@bitdancer for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 24, 2025
…-142517)The unknown-8bit trick was designed to deal with unknown bytes in anASCII message, and it works fine for that. However, I also tried toextend it to handle bytes that can't be decoded using the charsetspecified in an encoded word, and there it fails because there can beother non-ASCII characters that were *successfully* decoded. The fix issimple: do the unknown-8bit encoding using the utf-8 codec. This isespecially appropriate since anyone trying to do recovery on an unknownbyte string will probably attempt utf-8 first.(cherry picked from commit1e17ccd)Co-authored-by: R. David Murray <rdmurray@bitdance.com>
GH-143146 is a backport of this pull request to the3.14 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 24, 2025
…-142517)The unknown-8bit trick was designed to deal with unknown bytes in anASCII message, and it works fine for that. However, I also tried toextend it to handle bytes that can't be decoded using the charsetspecified in an encoded word, and there it fails because there can beother non-ASCII characters that were *successfully* decoded. The fix issimple: do the unknown-8bit encoding using the utf-8 codec. This isespecially appropriate since anyone trying to do recovery on an unknownbyte string will probably attempt utf-8 first.(cherry picked from commit1e17ccd)Co-authored-by: R. David Murray <rdmurray@bitdance.com>
GH-143147 is a backport of this pull request to the3.13 branch. |
bitdancer added a commit to bitdancer/cpython that referenced this pull requestDec 24, 2025
bitdancer added a commit that referenced this pull requestDec 24, 2025
bitdancer added a commit that referenced this pull requestDec 24, 2025
…H-142517) (#143147)The unknown-8bit trick was designed to deal with unknown bytes in anASCII message, and it works fine for that. However, I also tried toextend it to handle bytes that can't be decoded using the charsetspecified in an encoded word, and there it fails because there can beother non-ASCII characters that were *successfully* decoded. The fix issimple: do the unknown-8bit encoding using the utf-8 codec. This isespecially appropriate since anyone trying to do recovery on an unknownbyte string will probably attempt utf-8 first.(cherry picked from commit1e17ccd)Co-authored-by: R. David Murray <rdmurray@bitdance.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
bitdancer added a commit that referenced this pull requestDec 24, 2025
…H-142517) (#143146)The unknown-8bit trick was designed to deal with unknown bytes in anASCII message, and it works fine for that. However, I also tried toextend it to handle bytes that can't be decoded using the charsetspecified in an encoded word, and there it fails because there can beother non-ASCII characters that were *successfully* decoded. The fix issimple: do the unknown-8bit encoding using the utf-8 codec. This isespecially appropriate since anyone trying to do recovery on an unknownbyte string will probably attempt utf-8 first.(cherry picked from commit1e17ccd)Co-authored-by: R. David Murray <rdmurray@bitdance.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unknown-8bit trick was designed to deal with unknown bytes in an
ASCII message, and it works fine for that. However, I also tried to
extend it to handle bytes that can't be decoded using the charset
specified in an encoded word, and there it fails because there can be
other non-ASCII characters that weresuccessfully decoded. The fix is
simple: do the unknown-8bit encoding using the utf-8 codec. This is
especially appropriate since anyone trying to do recovery on an unknown
byte string will probably attempt utf-8 first.