NotificationsYou must be signed in to change notification settings
Fork34k
Star71.2k

gh-142163: Only define`HAVE_THREAD_LOCAL` when`Py_BUILD_CORE` is set#142164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 3 commits intopython:mainfromZeroIntensity:fix-numpy-shenanigans

Dec 2, 2025

Merged

gh-142163: Only define`HAVE_THREAD_LOCAL` when`Py_BUILD_CORE` is set#142164

kumaraditya303 merged 3 commits intopython:mainfromZeroIntensity:fix-numpy-shenanigans

Dec 2, 2025

Conversation

Copy link

Member

ZeroIntensity commentedDec 1, 2025•
edited by bedevere-appbot
Loading

Issue:python.h setting HAVE_THREAD_LOCAL breaks numpy build #142163

ZeroIntensity added3 commits

December 1, 2025 18:15

Only define HAVE_THREAD_LOCAL when Py_BUILD_CORE is set.

9161899

Add blurb.

fe4fb52

Improve blurb.

2321c5a

bedevere-appbot mentioned this pull request

Dec 1, 2025

python.h setting HAVE_THREAD_LOCAL breaks numpy build#142163

Closed

bedevere-appbot added the awaiting core review label

Dec 1, 2025

Copy link

MemberAuthor

ZeroIntensity commentedDec 1, 2025

@ngoldbaum Would you mind verifying that this fixes NumPy?

ZeroIntensity requested a review fromkumaraditya303

December 1, 2025 23:35

Copy link

Contributor

ngoldbaum commentedDec 1, 2025

Seems to work:

Python 3.15.0a2+ (heads/fix-numpy-shenanigans:2321c5a, Dec  1 2025, 16:34:55) [Clang 17.0.0 (clang-1700.4.4.1)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> import numpy>>> numpy.__version__'2.5.0.dev0+git20251201.fb0578d'>>>

Copy link

Contributor

tacaswell commentedDec 2, 2025

lol, I like the branch name.

I can confirm that this fixes it for both

✘ 21:43:47 [belanna] @ clang++ --versionclang version 21.1.6Target: x86_64-pc-linux-gnuThread model: posixInstalledDir: /usr/bin~✔ 21:43:53 [belanna] @ g++ --versiong++ (GCC) 15.2.1 20251112Copyright (C) 2025 Free Software Foundation, Inc.This is free software; see the source for copying conditions.  There is NOwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.