Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Open
Description
Bug report
This code raises aNameError
with the JIT disabled, and succeeds with the JIT enabled:
importtypesGLOBAL=42defmake_f():deff():returnGLOBALreturnfmake_f_with_bad_globals=types.FunctionType(make_f.__code__, {})defjitted(funcs):forfuncinfuncs:func()defmain():# Make a "good" f:f=make_f()# Compile jitted for the "good" f:jitted([f]*4096)# This "bad" f has different globals, but the *same* code/function versions:f_with_bad_globals=make_f_with_bad_globals()# A "good" f to enter the JIT code, and a "bad" f to trigger the bug:jitted([f,f_with_bad_globals])main()
We're relying on the function version to guarantee the correct globals. Functions that are created from the same code object share the same function version, butdon't necessarily share the same globals.
The fix is probably to insert runtime checks for the identity of the globals dictionary (instead of the function version) inremove_globals
. An identity check is safe, since if the original globals dict is deallocated then the trace will be invalidated anyways.