Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Description
Bug report
InPEP-749 I addedtyping.evaluate_forward_ref to replace the privatetyping.ForwardRef._evaluate, which is being used by some external users.
The currentdocumentation claims these differences fromannotationlib.ForwardRef.evaluate:
- Recursively evaluates forward references nested within the type hint.
- Raises TypeError when it encounters certain objects that are not valid type hints.
- Replaces type hints that evaluate to None with types.NoneType.
- Supports the FORWARDREF and STRING formats.
(1) is useful and fits well with the typing module; annotationlib can't do this because it requires introspecting into typing-specific objects. (2) I feel is not useful (compare#133959): the type check is not particularly thorough, and it's generally better for callers to allow more objects through that callers can handle on their own terms. (3) is sort of harmless but not particularly useful. (4) is not true any more since I also added support for these formats toForwardRef.evaluate.
So I'd like to drop differences 2 through 4, leaving the function focused on recursively evaluating nested ForwardRefs.