Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-133447: Add basic color tosqlite3 CLI#133461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sharktide left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems good to me
tomasr8 commentedMay 6, 2025
Now that#133347 has been merged, we could take advantage of it in the sqlite CLI as well? |
StanFromIreland commentedMay 6, 2025
cc@ambv Just to check -- did I use themes correctly or did I do something wrong (there is no docs at the moment to verify)? |
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, there are no docs so I'll push here with how I'd do it if that's okay.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let me know what you think.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
StanFromIreland commentedMay 6, 2025
Looks good to me now, thank you for the assistance:-) If you need help with colorise I’d be happy to lend a hand. |
ambv commentedMay 6, 2025
Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though. |
sqlite3 clisqlite3 CLIUh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland commentedMay 7, 2025
SQL highlighting would be awesome. |
StanFromIreland commentedMay 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All the test fails are unrelated.
Working on it :-) |
Uh oh!
There was an error while loading.Please reload this page.
erlend-aasland commentedMay 10, 2025
@StanFromIreland, please look into the failing tests. |
StanFromIreland commentedMay 10, 2025
I was testing the broken behavior that was now fixed, oops! |
StanFromIreland commentedMay 10, 2025
@erlend-aasland Test has been corrected to work with the new updates. |
30b1d8f intopython:mainUh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedMay 10, 2025
|
StanFromIreland commentedMay 10, 2025
Unrelated. |
Uh oh!
There was an error while loading.Please reload this page.
(pythongh-133447: Add basic color to `sqlite3` CLI (python#133461))
Uh oh!
There was an error while loading.Please reload this page.
request:@hugovk