NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-121468: Support async breakpoint in pdb#132576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gaogaotiantian merged 13 commits intopython:mainfromgaogaotiantian:support-async-breakpoint

Apr 29, 2025

Merged

gh-121468: Support async breakpoint in pdb#132576

gaogaotiantian merged 13 commits intopython:mainfromgaogaotiantian:support-async-breakpoint

Apr 29, 2025

Conversation

Copy link

Member

gaogaotiantian commentedApr 16, 2025•
edited by github-actionsbot
Loading

I finally figured out how to supportawait in pdb without too much hack - we can make the breakpoint itself an awaitable, and everything is simply integrated into the system!

This PR introduced a new functionpdb.set_trace_async which the users shouldawait, and with that function, the users can do theirawaits in th debugger!

Issue:Make pdb asyncio aware #121468

📚 Documentation preview 📚:https://cpython-previews--132576.org.readthedocs.build/

gaogaotiantian added3 commits

April 13, 2025 13:34

Add set_trace_async for async support

1b77cdb

Merge branch 'main' into support-async-breakpoint

285efe2

Update docs

677c952

bedevere-appbot mentioned this pull request

Apr 16, 2025

Make pdb asyncio aware#121468

Open

blurb-itbotand others added6 commits

April 16, 2025 01:41

📜🤖 Added by blurb_it.

15290d5

reorder the if checks

a3401e9

Add breakpoint tests

50c3c9c

Merge branch 'main' into support-async-breakpoint

a6c580d

Update test

090715b

Add whatsnew entry

ebdc161

gaogaotiantian marked this pull request as ready for review

April 16, 2025 23:44

bedevere-appbot added the awaiting core review label

Apr 16, 2025

gaogaotiantian requested review fromiritkatriel andkumaraditya303

April 16, 2025 23:44

Copy link

MemberAuthor

gaogaotiantian commentedApr 21, 2025

Hi@iritkatriel , do you think this needs to be reviewed by asyncio expert?

Copy link

Member

iritkatriel commentedApr 21, 2025

Yes, ideally.

Copy link

MemberAuthor

gaogaotiantian commentedApr 22, 2025

@kumaraditya303 I hope I can have this in 3.14 because it's a demanding feature. Could you take a look at it and see if it's a reasonable approach? Thanks!

kumaraditya303 reviewed

Apr 22, 2025

View reviewed changes

Lib/test/test_pdb.pyShow resolvedHide resolved

graingert-coef reviewed

Apr 22, 2025

View reviewed changes

Lib/pdb.py OutdatedShow resolvedHide resolved

graingert reviewed

Apr 22, 2025

View reviewed changes

Lib/pdb.py Outdated

		ande.msg=="'await' outside function"
		):
		try:
		self._exec_await(buffer,globals,locals)

Copy link

Contributor

graingertApr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should be run without the exception from line 891 in the context

Copy link

MemberAuthor

gaogaotiantianApr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I restructured the code as we know whether it is an await code during compile. The nice side effect is that we don't need to execute the code under the exception context.