Feature or enhancement

Proposal:

I was looking at the IPA inlining dump as part of investigating the root cause ofgh-132295 and noticed that we're inlining a number of slow path functions related to specialization, instrumentation, and error handling in the interpreter loop when performing LTO (full listhere):

_Py_Specialize_CallKw_Py_Specialize_CompareOp_Py_Specialize_ContainsOp_Py_Specialize_ForIter_Py_Specialize_LoadGlobal_Py_Specialize_LoadSuperAttr_Py_Specialize_Send_Py_Specialize_StoreAttr_Py_Specialize_StoreSubscr_Py_Specialize_ToBool_Py_Specialize_UnpackSequence_Py_call_instrumentation_Py_call_instrumentation_instruction_Py_call_instrumentation_lineget_exception_handler

I suspect these are being inlined because we use unit tests for collecting PGO data. These should be executed relatively infrequently for "normal" Python code. We should mark them asnoinline.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

• gh-132336: Mark a few "slow path" functions used by the interpreter loop as noinline #132337
• gh-132336: Only mark slow path functions used by the interpreter loop as noinline in free-threaded builds #132424