Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132285: Fix that__annotate__ is not deleted when__annotations__ is deleted#132286

Merged
JelleZijlstra merged 3 commits intopython:mainfrom
sobolevn:issue-132285
Apr 9, 2025
Merged

gh-132285: Fix that__annotate__ is not deleted when__annotations__ is deleted#132286
JelleZijlstra merged 3 commits intopython:mainfrom
sobolevn:issue-132285

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedApr 8, 2025•
edited by bedevere-appbot
Loading

@JelleZijlstra
Copy link
Member

I think this actually behaves incorrectly. Inhttps://peps.python.org/pep-0749/#effect-of-deleting-annotations we said that deleting__annotations__ should also delete__annotate__.type_set_annotations() tries to do that but it's buggy; do you want to fix it?

@sobolevn
Copy link
MemberAuthor

Yes, sure :)
Checkingtype_set_annotations

@sobolevnsobolevn changed the titlegh-132285: Add a test when__annotations__ is deletedgh-132285: Fix that__annotate__ is not deleted when__annotations__ is deletedApr 9, 2025
@JelleZijlstraJelleZijlstra merged commit2541103 intopython:mainApr 9, 2025
46 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@JelleZijlstra

Comments

[8]ページ先頭
©2009-2026 Movatter.jp