python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork34.1k
Star71.6k

Comments

gh-60115: Support frozen modules for linecache.getline()#131638

Merged

gaogaotiantian merged 7 commits intopython:mainfrom

gaogaotiantian:frozen-source

Apr 2, 2025

Merged

gh-60115: Support frozen modules for linecache.getline()#131638
gaogaotiantian merged 7 commits intopython:mainfrom
gaogaotiantian:frozen-source

Conversation

Copy link

Member

gaogaotiantian commentedMar 23, 2025•
edited by bedevere-appbot
Loading

When we try to get source lines for frozen modules withlinecache.getlines(), it will be rejected because frozen modules have file names starting with<. However, we can deal with that case, if we havemodule_globals - we can read__file__ inmodule_globals to get the real file and read it.

pdb suffers from it when debugging frozen modules -list deals with it but stack entry andll does not. I could fix it in pdb, but I thinklinecache could benefit from this change so it helps all users. This is also a pretty straighforward change, just convert the filename passed in to the actual file name and the rest is the same.

Issue:can't step through _frozen_importlib/importlib._bootstrap using pdb #60115

Support getting source file for frozen modules

7bbf5d6

gaogaotiantian requested review fromiritkatriel andpablogsal

March 23, 2025 18:38

bedevere-appbot added the awaiting core review label

Mar 23, 2025

bedevere-appbot mentioned this pull request

Mar 23, 2025

can't step through _frozen_importlib/importlib._bootstrap using pdb#60115

Open

📜🤖 Added by blurb_it.

31387a0

Copy link

MemberAuthor

gaogaotiantian commentedMar 23, 2025

Not sure if a whatsnew entry should be added for 3.14. Is this a significant enough change?

picnixz reviewed

Mar 23, 2025

View reviewed changes

Copy link

Member

picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some small nits. Maybe a test with a frozen module with some content or do we have no way to do it easily?

Misc/NEWS.d/next/Library/2025-03-23-18-39-07.gh-issue-60115.AWdcmq.rst OutdatedShow resolvedHide resolved

Lib/linecache.py OutdatedShow resolvedHide resolved

Lib/test/test_linecache.pyShow resolvedHide resolved

Apply suggestions from code review

c101cf9

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Copy link

MemberAuthor

gaogaotiantian commentedMar 23, 2025

Maybe a test with a frozen module with some content or do we have no way to do it easily?

The difficult part is to get the module global of it. It's not trivial to get the frame of a frozen module in linecache tests. However, after this, I'll polish pdb and I'll add more tests there to cover the real case. It's much easier (and practical) to do it in pdb.