Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Description
Bug report
Bug description:
This is an issue that only affects Windows DEBUG builds and Python 3.12. I discovered it while writing#127780 and@Yhg1s (#127780 (comment)) investigated it more in details.
The reproducer is as follows:
PS D:\Python\cpython> D:\\Python\\cpython\\PCbuild\\amd64\\_testembed_d.exe test_repeated_init_exec'import dis>> import importlib._bootstrap>> import opcode>> import test.test_dis>>>> def is_specialized(f):>> for instruction in dis.get_instructions(f, adaptive=True):>> opname = instruction.opname>> if (>> opname in opcode._specialized_instructions>> # Exclude superinstructions:>> and \"__\" not in opname>> ):>> return True>> return False>>>> func = importlib._bootstrap._handle_fromlist>>>> # "copy" the code to un-specialize it:>> func.__code__ = func.__code__.replace()>>>> assert not is_specialized(func), \"specialized instructions found\">>>> for i in range(test.test_dis.ADAPTIVE_WARMUP_DELAY):>> func(importlib._bootstrap, [\"x\"], lambda *args: None)>>>> assert is_specialized(func), \"no specialized instructions found\">>>> print(\"Tests passed\")'--- Loop#1 ---Tests passed--- Loop#2 ---Assertion failed: PyUnicode_CheckExact(ep->me_key), file D:\Python\cpython\Objects\dictobject.c, line939
Paraphrasing Thomas, the assertion failure happens only thesecond time, namely after finalizing and reinitializing, and theep the assertion fails on is a deallocated object. We suspect that something isn't refcounted correctly, isn't marked as immortal when it should be, or isn't recreated on interpreter starutp when it should be. However, we don't why the issue does not appear on Linux.
According to Thomas, this is likely an issue with repeated calls toPy_Finalize andPy_Initialize. However, since 3.12 and 3.13 manage objects lifetime quite differently, it might be easier to just patch the test currently failing as follows:68a33f3.
CPython versions tested on:
3.12
Operating systems tested on:
Windows, Linux