Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
gh-128473: Skip segfaultingtest_embed tests when BOLT instrumented#128474
Merged
corona10 merged 2 commits intopython:mainfromJan 15, 2025
Merged
gh-128473: Skip segfaultingtest_embed tests when BOLT instrumented#128474corona10 merged 2 commits intopython:mainfrom
test_embed tests when BOLT instrumented#128474corona10 merged 2 commits intopython:mainfrom
Conversation
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
corona10 approved these changesJan 15, 2025
Member
corona10 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!
Sorry for the late. next time please assign me for the BOLT related PRs :)
Too many Github notifications make me miss this PR.
6e4f641 intopython:main 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
zanieb commentedJan 15, 2025
@corona10 sounds good, can do! |
jjhelmus added a commit to astral-sh/python-build-standalone that referenced this pull requestDec 10, 2025
A version of `patch-test-embed-prevent-segfault.patch` was mergedupstream inpython/cpython#128474. It is notneeded in CPython 3.14+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Patch authored by@indygreg
I don't think this shouldclose#128473 — we should investigate the segfault.
test_embedsegfaults on BOLT instrumented binaries #128473