Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-128049: Fix type confusion bug with the return value of a custom ExceptionGroup split function#128079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
iritkatriel commentedDec 18, 2024
Labelling as do not merge until discussion on the issue is resolved. |
Misc/NEWS.d/next/Core_and_Builtins/2024-12-18-14-22-48.gh-issue-128079.SUD5le.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
iritkatriel left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good. I just made a few stylistic suggestions.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
iritkatriel commentedDec 20, 2024
Thank you@Nico-Posada ! |
3879ca0 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@Nico-Posada for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…stom ExceptionGroup split function (pythonGH-128079)(cherry picked from commit3879ca0)Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
…stom ExceptionGroup split function (pythonGH-128079)(cherry picked from commit3879ca0)Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com>
GH-128139 is a backport of this pull request to the3.13 branch. |
GH-128140 is a backport of this pull request to the3.12 branch. |
…stom ExceptionGroup split function (python#128079)
…stom ExceptionGroup split function (python#128079)
Uh oh!
There was an error while loading.Please reload this page.
Fixes#128049
Still new to this whole process so feedback is appreciated :)