Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
gh-126014: Ignore__pycache__-only folders in makefile tests#126066
Merged
sobolevn merged 2 commits intopython:mainfromOct 29, 2024
Merged
gh-126014: Ignore__pycache__-only folders in makefile tests#126066sobolevn merged 2 commits intopython:mainfrom
__pycache__-only folders in makefile tests#126066sobolevn merged 2 commits intopython:mainfrom
Conversation
furkanonder approved these changesOct 28, 2024
Contributor
furkanonder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
tomasr8 approved these changesOct 28, 2024
Member
tomasr8 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! :) I ran into this again today while working on some tests 😄
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 29, 2024
…ythonGH-126066)(cherry picked from commitaeafaf4)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 29, 2024
…ythonGH-126066)(cherry picked from commitaeafaf4)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
GH-126109 is a backport of this pull request to the3.13 branch. |
GH-126110 is a backport of this pull request to the3.12 branch. |
sobolevn added a commit that referenced this pull requestOct 29, 2024
…GH-126066) (#126110)gh-126014: Ignore `__pycache__`-only folders in makefile tests (GH-126066)(cherry picked from commitaeafaf4)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
sobolevn added a commit that referenced this pull requestOct 29, 2024
…GH-126066) (#126109)gh-126014: Ignore `__pycache__`-only folders in makefile tests (GH-126066)(cherry picked from commitaeafaf4)Co-authored-by: sobolevn <mail@sobolevn.me>Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull requestDec 8, 2024
…ython#126066)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull requestJan 12, 2025
…ython#126066)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
__pycache__intest_makefile_test_folders#126014