Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Re-enable skipped test_zlib tests on s390x hardware acceleration #125041

Closed
Assignees
encukou
Labels
pendingThe issue will be closed if no feedback is providedtestsTests in the Lib/test dir
@encukou

Description

@encukou

Some variants of the s390x platform have instructions for hardware-accelerated deflate compression. With HW acceleration, compressed byte stream can be different from the software implementation in zlib. (It still decompresses to the original of course.)
The zlib-ng library can be built to use this, and CPython can be built with zlib-ng.

In 2022 (#90781,GH-31096), two tests that failed on s390x were unconditionally skipped. IMO, it would be better if we only skip checking the compressed stream, butdo check the round-trip result.
Testing should be a bit easier now that a buildbot worker has the HW-accelerated zlib.

In#107535, theskip_on_s390x variable was separated from the comment that explains it.
I propose to name the skip conditionHW_ACCELERATED rather thanskip_on_s390x -- theoretically, other platforms might need this in the future.

Linked PRs

Metadata

Metadata

Assignees

Labels

pendingThe issue will be closed if no feedback is providedtestsTests in the Lib/test dir

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions


    [8]ページ先頭

    ©2009-2025 Movatter.jp