Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
Support the "pager" binary in _pyrepl#122878
Merged
vstinner merged 4 commits intopython:mainfromSep 19, 2024
Merged
Conversation
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policyThis is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555
vstinner approved these changesSep 18, 2024
Member
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. IMO it's reasonable to trypager beforeless. On Fedora, there is nopager command, it will silently be ignored as expected which is fine.
Member
skirpichev commentedSep 19, 2024
It's user-visible change, I think it worth a changelog entry. |
Member
vstinner commentedSep 19, 2024
@stefanor: Seehttps://devguide.python.org/ for how to add a Changelog (NEWS) entry. |
ContributorAuthor
stefanor commentedSep 19, 2024
Added a NEWS entry. |
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-122878.4iFpsB.rst
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…e-122878.4iFpsB.rstCo-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
skirpichev approved these changesSep 19, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 19, 2024
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555(cherry picked from commit426569e)Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
GH-124242 is a backport of this pull request to the3.13 branch. |
Member
vstinner commentedSep 19, 2024
Merged, thanks@stefanor. |
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull requestSep 22, 2024
Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555
vstinner pushed a commit that referenced this pull requestOct 7, 2024
Support the "pager" binary in _pyrepl (GH-122878)Debian (and derivatives) provide a /usr/bin/pager binary, managed by thealternatives system, that always points to an available pager utility.Allow _pyrepl to use it, to follow system policy.This is a very trivial change, from a patch that Debian has beencarrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555(cherry picked from commit426569e)Co-authored-by: Stefano Rivera <stefano@rivera.za.net>Co-authored-by: T. Wouters <thomas@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy
This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream.https://bugs.debian.org/799555