Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Closed
Description
Bug report
Bug description:
Infilecmp.cmpfiles, when the path is not stat-able, it will be put in the "fancy" files. This should include paths that would raiseValueError.
Note thatfilecmp.cmp shouldnot be protected against that since it already ignores an OSError possibly raised byos.stat.
Similarly,filecmp.dircmp should not suppressOSError orValueError when listing the directory contents. It should however silenceValueError when checking the common files since it already silence anOSError.
TL;DR: Only protect againstValueError if the current code is already protecting againstOSError.
CPython versions tested on:
CPython main branch
Operating systems tested on:
No response