Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove remnants of support for non-IEEE 754 systems from cmathmodule.c #121268

Closed
Labels
type-featureA feature request or enhancement
@skirpichev

Description

@skirpichev

Feature or enhancement

Proposal:

Proposed patch:

diff --git a/Modules/cmathmodule.c b/Modules/cmathmodule.cindex bf86a211bc..591442334e 100644--- a/Modules/cmathmodule.c+++ b/Modules/cmathmodule.c@@ -185,15 +185,8 @@ cmath_acos_impl(PyObject *module, Py_complex z)     if (fabs(z.real) > CM_LARGE_DOUBLE || fabs(z.imag) > CM_LARGE_DOUBLE) {         /* avoid unnecessary overflow for large arguments */         r.real = atan2(fabs(z.imag), z.real);-        /* split into cases to make sure that the branch cut has the-           correct continuity on systems with unsigned zeros */-        if (z.real < 0.) {-            r.imag = -copysign(log(hypot(z.real/2., z.imag/2.)) +-                               M_LN2*2., z.imag);-        } else {-            r.imag = copysign(log(hypot(z.real/2., z.imag/2.)) +-                              M_LN2*2., -z.imag);-        }+        r.imag = -copysign(log(hypot(z.real/2., z.imag/2.)) ++                           M_LN2*2., z.imag);     } else {         s1.real = 1.-z.real;         s1.imag = -z.imag;@@ -386,11 +379,7 @@ cmath_atanh_impl(PyObject *module, Py_complex z)         */         h = hypot(z.real/2., z.imag/2.);  /* safe from overflow */         r.real = z.real/4./h/h;-        /* the two negations in the next line cancel each other out-           except when working with unsigned zeros: they're there to-           ensure that the branch cut has the correct continuity on-           systems that don't support signed zeros */-        r.imag = -copysign(Py_MATH_PI/2., -z.imag);+        r.imag = copysign(Py_MATH_PI/2., z.imag);         errno = 0;     } else if (z.real == 1. && ay < CM_SQRT_DBL_MIN) {         /* C99 standard says:  atanh(1+/-0.) should be inf +/- 0i */

Removing this legacy wasproposed in#102067, butbefore merging#31790. Maybe now that change does make sense?

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

#102067 (comment)

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp