Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator#118648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Daverball commentedMay 6, 2024
It might be worth considering also updating But we can also save it for a follow-up PR, if you'd prefer that. A change in typeshed doesn't make sense until we test 3.13 to the CI. |
JelleZijlstra commentedMay 6, 2024
@Daverball Possibly, but note that we're one day away from the feature freeze for Python 3.13. I can spend some time on it later today, but please open a separate issue first. @AlexWaygood if you have time, could you review this PR that just adds defaults for Generator and AsyncGenerator? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
graingert commentedMay 6, 2024
|
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
mikeshardmind commentedMay 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I would hope this isn't a real blocker here. From a user standpoint, users are told
(https://docs.python.org/3/library/typing.html#typing.Generator) If this deprecation results in them not being equivalent anymore, you've broken the documented idea of them being equivalent. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
…erator (python#118648)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--118648.org.readthedocs.build/