Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111744: Makebreakpoint() enter the debugger immediately#118579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 6 commits intopython:mainfromgaogaotiantian:pdb-breakpoint
May 5, 2024

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedMay 4, 2024•
edited by github-actionsbot
Loading

We had some discussion in#111744 and in discord channel. We know this is a breaking change but people agree it's much more intuitive.

This basically changes thebreakpoint() andpdb.set_trace() behavior so it stops immediately after the call, rather than before the next line.

Unfortunately a lot of the test cases need to be adapted.

📚 Documentation preview 📚:https://cpython-previews--118579.org.readthedocs.build/

oneroyalace reacted with hooray emoji
@brandtbucher
Copy link
Member

this is a breaking change

Haha.

Away from my computer now, but I’ll take a look at this today.

@brandtbucherbrandtbucher self-assigned thisMay 4, 2024
@gaogaotiantian
Copy link
MemberAuthor

this is a breaking change

Haha.

Pun is actually not intended. Took me a second to realize what's funny :)

@ambv
Copy link
Contributor

ambv commentedMay 4, 2024

This is a breaking change but I can't tell you how many times I wanted to look at the state of a function, I putbreakpoint() at the last line... and it stopped after leaving the function altogether 😵‍💫

So this is great to see!

@brandtbucher
Copy link
Member

Test changes look good. Thanks for applying a variety of fixes there.

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this! I'll leave it open for a bit in case others have thoughts.

@brandtbucherbrandtbucher merged commit5a0022a intopython:mainMay 5, 2024
35 checks passed
@gaogaotiantiangaogaotiantian deleted the pdb-breakpoint branchMay 5, 2024 17:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

@brandtbucherbrandtbucher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@gaogaotiantian@brandtbucher@ambv
[8]ページ先頭
©2009-2025 Movatter.jp