Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Closed
Description
In bytecodes.c we use bothnext_instr - this_instr and1 + INLINE_CACHE_ENTRIES_... to mean "instruction length".
We should add a macro for the purpose that is understood by the code generator.
Examples
The somewhat confusingLOAD_IP(1 + INLINE_CACHE_ENTRIES_SEND); would becomeLOAD_IP(INSTRUCTION_LENGTH)
frame->return_offset = (uint16_t)(next_instr - this_instr); would becomeframe->return_offset = INSTRUCTION_LENGTH; which is both easier to understand and wouldn't be rejected as tier 2 code.