Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Description
Bug report
Bug description:
The CPython sources include a vendored copy ofhttps://github.com/microsoft/mimalloc.
This was added 5 months ago as part of#109914. the commit comment says it is version "v2.12". That doesn't appear to be a mimalloc release, but v2.1.2 does exist, and was the current stable release as of November 2023.
However, that code referencesTARGET_IOS_IPHONE
andTARGET_IOS_SIMULATOR
. These symbols were deprecated in iOS 15 (released ~2 years ago). These references have been updated in the dev branch ofmimalloc
(along with many other changes), but there isn't an updated stable mimalloc release at time of writing.
We have also made a number of other changes to the vendored version (about 18 commits, by my count). It's not clear if these mirror changes that have been made upstream, or if we have effectively forked mimalloc at this point.
The code still appears to work at present, but there's a risk it might not in future when the symbol deprecations are finalised. There may also be other updates and bugfixes in mimalloc that we're not taking advantage of.
This was discovered during an audit ofTARGET_OS
symbol usage following the report of#117886 and#117891.
CPython versions tested on:
CPython main branch
Operating systems tested on:
macOS