Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-115882: Add missing #include <Unknwn.h> on Windows#115350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 2 commits intopython:mainfromgeorgthegreat:patch-1
Feb 26, 2024

Conversation

@georgthegreat
Copy link
Contributor

@georgthegreatgeorgthegreat commentedFeb 12, 2024
edited
Loading

@ghost
Copy link

ghost commentedFeb 12, 2024
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@georgthegreatgeorgthegreat changed the titleAdd missing #include <Unknwn.h> on Windowsgh-115882: Add missing #include <Unknwn.h> on WindowsFeb 24, 2024
@georgthegreat
Copy link
ContributorAuthor

georgthegreat commentedFeb 24, 2024
edited
Loading

Could anyone mark this with skip news label to get the CI green?

@hugovk
Copy link
Member

This should have a NEWS entry, please can you add one?

@georgthegreat
Copy link
ContributorAuthor

georgthegreat commentedFeb 24, 2024
edited
Loading

@hugovk, it looks like generating files inMisc/News.d/next is automated somehow.
It there any guide on how do I add an entry atop of the existing PR?

UPD: managed to do this by myself, sorry for disturbing.

hugovk reacted with thumbs up emoji

@georgthegreat
Copy link
ContributorAuthor

NB: this is not the only patch needed to build CPython with this define.

I will have to dig through our patch set to get the remaining ones.

@georgthegreat
Copy link
ContributorAuthor

@hugovk, the CI is green, so two questions arise.

  1. Can we proceed with merging this PR?
  2. Is there a chance for this PR to be backported to 3.12 branch? Updating to 3.13 is a huge amount of work in our case and we would like to remove as many patches as possible prior to doing that.

@hugovk
Copy link
Member

  1. Can we proceed with merging this PR?

I'll leave it to a Windows expert to review.

  1. Is there a chance for this PR to be backported to 3.12 branch? Updating to 3.13 is a huge amount of work in our case and we would like to remove as many patches as possible prior to doing that.

Generally, bug fixes can be backported for all bugfix branches -- seehttps://devguide.python.org/versions/ -- currently 3.11 and 3.12. Again, I'll leave it to a Windows expert to decide.

@zooba
Copy link
Member

This one is fine. But no promises that the rest will be fine - I've definitely fixed issues recently by removingLEAN_AND_MEAN specifications, and I'd rather keep them in than start referencing non-top-level header files directly.

I see no reason to backport, as this doesn't fix a bug (neither us nor Microsoft make any promises about things being buildable withWIN32_LEAN_AND_MEAN). Keep the patches up and you may be able to drop all your own patches for 3.13 onwards, but you'll want to hang onto them for 3.12 and prior.

hugovk reacted with thumbs up emoji

@zoobazooba merged commit96c10c6 intopython:mainFeb 26, 2024
@georgthegreatgeorgthegreat deleted the patch-1 branchFebruary 26, 2024 17:54
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgthegreat@hugovk@zooba

[8]ページ先頭

©2009-2025 Movatter.jp