Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-115882: Add missing #include <Unknwn.h> on Windows#115350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedFeb 12, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
georgthegreat commentedFeb 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Could anyone mark this with skip news label to get the CI green? |
hugovk commentedFeb 24, 2024
This should have a NEWS entry, please can you add one? |
georgthegreat commentedFeb 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@hugovk, it looks like generating files in UPD: managed to do this by myself, sorry for disturbing. |
georgthegreat commentedFeb 24, 2024
NB: this is not the only patch needed to build CPython with this define. I will have to dig through our patch set to get the remaining ones. |
georgthegreat commentedFeb 26, 2024
@hugovk, the CI is green, so two questions arise.
|
hugovk commentedFeb 26, 2024
I'll leave it to a Windows expert to review.
Generally, bug fixes can be backported for all bugfix branches -- seehttps://devguide.python.org/versions/ -- currently 3.11 and 3.12. Again, I'll leave it to a Windows expert to decide. |
zooba commentedFeb 26, 2024
This one is fine. But no promises that the rest will be fine - I've definitely fixed issues recently by removing I see no reason to backport, as this doesn't fix a bug (neither us nor Microsoft make any promises about things being buildable with |
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350)This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
Uh oh!
There was an error while loading.Please reload this page.
Fix building ctypes module with
-DWIN32_LEAN_AND_MEANdefined.See:
https://learn.microsoft.com/en-us/windows/win32/api/unknwn/nn-unknwn-iunknown