Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

vcruntime140_threads.dll is erroneously vendored when building with Visual Studio 17.8 #115167

Closed
Labels
OS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error
@adang1345

Description

@adang1345

Bug report

Bug description:

As described inhttps://devblogs.microsoft.com/cppblog/c11-threads-in-visual-studio-2022-version-17-8-preview-2/, Visual Studio 17.8 introduced support for C11 threads, provided byvcruntime140_threads.dll. When I use theTools\msi\buildrelease.bat script to build Python 3.12.2 on Windows using this Visual Studio version, thevcruntime140_threads.dll ends up in the Python distribution. For instance, thepython-3.12.2-embed-amd64.zip file that is built contains the filevcruntime140_threads.dll at its root.

I traced the cause of this to

<VCRuntimeDLLInclude="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
which copies all DLLs matching the patternvcruntime*.dll from the Visual C++ runtime directory. Starting with Visual Studio 17.8, this directory (which for me isC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Redist\MSVC\14.38.33135\x64\Microsoft.VC143.CRT) contains the filevcruntime140_threads.dll.

Given that we aren't using C11 threads on Windows, I think we should change that line to
<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" Exclude="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*_threads.dll" /> to ensure that the file is not included in the Python distribution. I can make a PR for this change.

CPython versions tested on:

3.12

Operating systems tested on:

Windows

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-windowsbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp