Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Description
Bug report
Bug description:
As described inhttps://devblogs.microsoft.com/cppblog/c11-threads-in-visual-studio-2022-version-17-8-preview-2/, Visual Studio 17.8 introduced support for C11 threads, provided byvcruntime140_threads.dll. When I use theTools\msi\buildrelease.bat script to build Python 3.12.2 on Windows using this Visual Studio version, thevcruntime140_threads.dll ends up in the Python distribution. For instance, thepython-3.12.2-embed-amd64.zip file that is built contains the filevcruntime140_threads.dll at its root.
I traced the cause of this to
cpython/PCbuild/pyproject.props
Line 253 in17689e3
| <VCRuntimeDLLInclude="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" /> |
vcruntime*.dll from the Visual C++ runtime directory. Starting with Visual Studio 17.8, this directory (which for me isC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Redist\MSVC\14.38.33135\x64\Microsoft.VC143.CRT) contains the filevcruntime140_threads.dll.Given that we aren't using C11 threads on Windows, I think we should change that line to<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" Exclude="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*_threads.dll" /> to ensure that the file is not included in the Python distribution. I can make a PR for this change.
CPython versions tested on:
3.12
Operating systems tested on:
Windows