NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-112795: Allow`/` folder in a zipfile#112932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 5 commits intopython:mainfromaisk:root-in-zipfile

Jan 7, 2024

Merged

gh-112795: Allow`/` folder in a zipfile#112932

gpshead merged 5 commits intopython:mainfromaisk:root-in-zipfile

Jan 7, 2024

Conversation

Copy link

Contributor

aisk commentedDec 10, 2023•
edited
Loading

This behavior is introduced in#98346 (comment), but as#112795 shows, some tools such as jira or self structeded tools do have/ in the file lists in the created zip file. And modern unzip tools support them, so I think we should revert the change.

If this PR can be accepted, it should be backported to 3.12.

Issue:zlib extractall can not extract zip because of '/' in namelist #112795

allow / folder in a zipfile

b836b78

aisk requested a review fromjaraco as acode owner

December 10, 2023 14:14

bedevere-appbot added the awaiting review label

Dec 10, 2023

bedevere-appbot mentioned this pull request

Dec 10, 2023

zlib extractall can not extract zip because of '/' in namelist#112795

Closed

fix linter errors

cad2a1f

Copy link

Contributor

erlend-aasland commentedJan 6, 2024

cc.@gpshead, who reviewed and merged#98346

Merge branch 'main' into root-in-zipfile

ace82dc

erlend-aasland changed the title~~gh-112795: allow/ folder in a zipfile~~gh-112795: Allow/ folder in a zipfile

Jan 6, 2024

gpshead self-assigned this

Jan 6, 2024

gpshead reviewed

Jan 6, 2024

View reviewed changes

Lib/zipfile/__init__.pyShow resolvedHide resolved

gpshead added needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Jan 6, 2024

gpshead added2 commits

January 6, 2024 15:44

Keep the empty filename check, just not on directories.

3773d98

NEWS entry.

0f05ac9

gpshead removed the needs backport to 3.11only security fixes label

Jan 7, 2024

gpsheadenabled auto-merge (squash)

January 7, 2024 01:09

gpshead merged commit541c5db intopython:main

Jan 7, 2024

This comment was marked as outdated.

bedevere-appbot removed the awaiting review label

Jan 7, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 7, 2024

pythongh-112795: Allow/folder in a zipfile (pythonGH-112932)

1ae6a6b

Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools.(cherry picked from commit541c5db)Co-authored-by: AN Long <aisk@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>

Copy link

bedevere-appbot commentedJan 7, 2024

GH-113789 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Jan 7, 2024

gpshead added a commit that referenced this pull request

Jan 7, 2024

[3.12]gh-112795: Allow/folder in a zipfile (GH-112932) (#113789)

db6f297

gh-112795: Allow `/` folder in a zipfile (GH-112932)Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools.(cherry picked from commit541c5db)Co-authored-by: AN Long <aisk@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>