This issue has been there sinceday 1 and no one finds it in 2 years. It's not documented and it's not used internally. Is this just dead code@jaraco ?

Thanks@gaogaotiantian for tracking down the origin of the issue. Although that's day 1 for this class, the code is derived from resources.py in that commit.

In the upstream implementation (which probably has better fidelity of the history of this change),that file is skipped for coverage checks. That module was provided as an illustration of the lowest level interfaces required to supplyTraversableResources. It's entirely conceivable that no one has made use of them. This code was made in response topython/importlib_resources#90.

If we accept this change (and we probably should), we'll want to make sure it gets ported upstream.

I've cherry-picked this change into python/importlib_resources and released it as 6.1.1. This change will make it into CPython in due time. If you want to author a news fragment, I'll merge this change.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

My question is, if no one has used this piece of code for 2 years and it's not documented at all, do we still need it in CPython repo?

My question is, if no one has used this piece of code for 2 years and it's not documented at all, do we still need it in CPython repo?

Probably not, but to remove it will require a deprecation and we'll want to present that deprecation first in importlib_resources. Feel free to propose that there. In the meantime, it makes sense to merge the bugfix.

Oh, I thought removing code that we never documented does not require anything. But yeah, the fix itself definitely makes sense.

I have made the requested changes; please review again

Is something required of me here?

What needs to be done to merge this PR?

Thanks for your patience. I had a rough winter, so missed the notifications. Merging now.

Thanks@shadchin for the PR, and@jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

GH-115716 is a backport of this pull request to the3.12 branch.

GH-115717 is a backport of this pull request to the3.11 branch.