NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-111159: Fix`SyntaxError` doctests for non-builtin exception classes#111541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

iritkatriel merged 6 commits intopython:mainfromsobolevn:issue-111159-2

Nov 4, 2023

Merged

gh-111159: Fix`SyntaxError` doctests for non-builtin exception classes#111541

iritkatriel merged 6 commits intopython:mainfromsobolevn:issue-111159-2

Nov 4, 2023

Conversation

Copy link

Member

sobolevn commentedOct 31, 2023•
edited by bedevere-appbot
Loading

Issue:doctest fails to compare tracebacks with notes #111159

pythongh-111159: FixSyntaxErrordoctests for non-builtin exception…

9fa1722

… classes

sobolevn requested review fromiritkatriel andscoder

October 31, 2023 12:30

bedevere-appbot mentioned this pull request

Oct 31, 2023

doctest fails to compare tracebacks with notes#111159

Closed

bedevere-appbot added the awaiting review label

Oct 31, 2023

scoder approved these changes

Oct 31, 2023

View reviewed changes

Copy link

Contributor

scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks almost good to me, just a performance+readability remark.

Lib/doctest.py OutdatedShow resolvedHide resolved

bedevere-appbot added awaiting merge and removed awaiting review labels

Oct 31, 2023

sobolevn added the skip news label

Oct 31, 2023

Address review

42e2887

scoder reviewed

Oct 31, 2023

View reviewed changes

Copy link

Contributor

scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about this?

Lib/doctest.py OutdatedShow resolvedHide resolved

Apply suggestions from code review

7d388e2

Co-authored-by: scoder <stefan_ml@behnel.de>

sobolevn commented

Nov 1, 2023

View reviewed changes

Lib/test/test_doctest.py OutdatedShow resolvedHide resolved

Apply suggestions from code review

1c03d66

Copy link

Contributor

scoder commentedNov 1, 2023

Looks good now.
This fixes a bug introduced in 3.13a1. Not sure what the current policy is – would that suggest adding a news entry for 3.13a2?

Add news

84177b2

sobolevn removed the skip news label

Nov 4, 2023

sobolevn requested a review fromscoder

November 4, 2023 07:24

Update 2023-11-04-10-24-25.gh-issue-111541.x0RBI1.rst

e545306

iritkatriel approved these changes

Nov 4, 2023

View reviewed changes

iritkatriel added type-bug

An unexpected behavior, bug, or error

stdlib

Standard Library Python modules in the Lib/ directory

needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Nov 4, 2023

iritkatriel merged commit18c9548 intopython:main

Nov 4, 2023

Copy link

miss-islington-appbot commentedNov 4, 2023

Thanks@sobolevn for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

Nov 4, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 4, 2023

pythongh-111159: FixSyntaxErrordoctests for non-builtin exception…

8c2ac1d

… classes (pythonGH-111541)(cherry picked from commit18c9548)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 4, 2023

pythongh-111159: FixSyntaxErrordoctests for non-builtin exception…

1ace32d

… classes (pythonGH-111541)(cherry picked from commit18c9548)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Copy link

bedevere-appbot commentedNov 4, 2023

GH-111732 is a backport of this pull request to the3.12 branch.

bedevere-appbot removed the needs backport to 3.12only security fixes label

Nov 4, 2023

Copy link

bedevere-appbot commentedNov 4, 2023

GH-111733 is a backport of this pull request to the3.11 branch.

bedevere-appbot removed the needs backport to 3.11only security fixes label

Nov 4, 2023

Copy link

MemberAuthor

sobolevn commentedNov 4, 2023

Thanks everyone! 👍

iritkatriel pushed a commit that referenced this pull request

Nov 4, 2023

[3.11]gh-111159: FixSyntaxErrordoctests for non-builtin exceptio…

425efc1

…n classes (GH-111541) (#111733)gh-111159: Fix `SyntaxError` doctests for non-builtin exception classes (GH-111541)(cherry picked from commit18c9548)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

iritkatriel pushed a commit that referenced this pull request

Nov 4, 2023

[3.12]gh-111159: FixSyntaxErrordoctests for non-builtin exceptio…

3b839cc

…n classes (GH-111541) (#111732)gh-111159: Fix `SyntaxError` doctests for non-builtin exception classes (GH-111541)(cherry picked from commit18c9548)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024