Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-110722: Add PYTHON_PRESITE to import a module before site.py is run#110769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… before site.py is runThis is only available --with-pydebug.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It may be interesting to make this feature to release build.
For the doc, I suggest to replacepackage.module withmodule. You can explain in the doc that the argument can be a module of a package, with an example. I don't know.
Overall, the implementation looks correct.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
gpshead left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM - some minor cleanup to do, feel free to merge after that if CI says "ano" (CZ)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm fine with the C implementation and the overall feature, I just have some remarks on the doc.
I suggest to replacesite.py withthe site module. In Sphinx, you can even create a link if you want:
the :mod:`site` moduleThe presite module isimported, it's exactlyrun. But I'm fine withrun_presite name :-) Well, in fact, it can be seed as being "run" ;-)
Uh oh!
There was an error while loading.Please reload this page.
vstinner commentedOct 15, 2023
Congrats! |
Uh oh!
There was an error while loading.Please reload this page.
This is only available --with-pydebug.
📚 Documentation preview 📚:https://cpython-previews--110769.org.readthedocs.build/