Bug report

This code is problematic:

It does rewrite errors that happened before. Showing the last error, not the first one.
This goes against Python's semantics.

Here's the reproducer:

>>>importtermios>>>termios.tcsetattr(0,0, [0,1,2,'3',4,5,6])Traceback (mostrecentcalllast):File"<stdin>",line1,in<module>TypeError:'str'objectcannotbeinterpretedasaninteger>>>termios.tcsetattr(0,0, [object(),1,2,'3',4,5,6])Traceback (mostrecentcalllast):File"<stdin>",line1,in<module>TypeError:'str'objectcannotbeinterpretedasaninteger

The second error should say:

>>>termios.tcsetattr(0,0, [object(),1,2,'3',4,5,6])Traceback (mostrecentcalllast):File"<stdin>",line1,in<module>TypeError:'object'objectcannotbeinterpretedasaninteger

And while we are there we can also changePyList_GetItem toPyList_GET_ITEM, because:

• term is known to be alist
• the size ofterm is known to be 7
  See check

  cpython/Modules/termios.c

  Lines 197 to 201 inbf4bc36

  	if (!PyList_Check(term)||PyList_Size(term)!=7) {
  	PyErr_SetString(PyExc_TypeError,
  	"tcsetattr, arg 3: must be 7 element list");
  	returnNULL;
  	}

  before these lines.

The only problem is tests. I think thattermios is not tested that much in our suite. We don't even havetest_termios.py file. Should I add one?

Refs#110260

Linked PRs

• gh-110365: Fix error overwrite intermios.tcsetattr #110366
• [3.12] gh-110365: Fix error overwrite intermios.tcsetattr (GH-110366) #110389
• [3.11] gh-110365: Fix error overwrite intermios.tcsetattr (GH-110366) #110390