Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Closed
Description
Thedestination <name> clear
command is documented like this:
It removes all the accumulated text up to this point in the destination. (I don’t know what you’d need this for, but I thought maybe it’d be useful while someone’s experimenting.)
Clearly, the last sentence is correct, because this command contains two bugs, and nobody has ever complained:
- It accessesthe wrong attribute when clearing the accumulators
- The directive parserdoes not return immediately after executing the
clear
command, so it jumps straight into "fail because we got an unknown command"
The fixes are easy, so I suggest we apply the fixes and add regressions tests. An alternative could be to remove theclear
command, but I don't think we should tear out features lightly, no matter how obscure they are.
Found while working on#106935.