Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Closed
Description
Bug report
Synopsis
Forgetting to close TLS connections manually withasyncio.open_connection() will lead to a leak of TCP connection when the writer/reader get out of scope
Note: the reference is properly released when the remote side closes the connection
This seems to be counter intuitive relative to other python APIs where the connection is closed when the handle goes out of scope
Details
- open a TLS connection with
asyncio.open_connection(..., ssl=True) - do some read/writes
- exit function, so handlers get out of scope (and possibly gc collected). This may be due to an exception for example
- donot call
writer.close() - the connection is now "unreachable" from a user point of view
- however the TCP connection is kept alive
When trying to debug this issue I found out that a_SSLProtocolTransport instance is kept in memory, probably linked to the eventloop
Example script
importosimportasyncioimportgcimportsignalHOST="google.fr"# will keep the connection alive for a few minutes at leastasyncdefquery():reader,writer=awaitasyncio.open_connection(HOST,443,ssl=True)# No connection: close, remote side will keep the connection openwriter.write(f"GET / HTTP/1.1\r\nHost:{HOST}\r\n\r\n".encode())awaitwriter.drain()# only read the first header linetry:return (awaitreader.readline()).decode()finally:# closing the writer will properly finalize the connection# writer.close()pass# reader and writer are now unreachableasyncdefamain():awaitquery()# The _SSLProtocolTransport object is kept in memory and the# connection won't be released until the remote side closes the connectionfor_inrange(200):# Just be sure everything is freed, just in casegc.collect()awaitasyncio.sleep(1)defmain():print(f"PID{os.getpid()}")task=asyncio.ensure_future(amain())loop=asyncio.get_event_loop()loop.add_signal_handler(signal.SIGTERM,task.cancel)loop.add_signal_handler(signal.SIGINT,task.cancel)loop.run_until_complete(task)if__name__=="__main__":main()
Your environment
- CPython versions tested on:
- 3.11.4
- 3.10.11
- Operating system and architecture: Debian Linux 5.19 x86_64
Linked PRs
- GH-106684: raise ResourceWarning when StreamWriter is not closed #107650
- [3.12] GH-106684: Close
asyncio.StreamWriterwhenasyncio.StreamWriteris not closed by application (GH-107650) #107656 - [3.11] GH-106684: raise
ResourceWarningwhenasyncio.StreamWriteris not closed (GH-107650) #107657 - [3.11] [3.12] GH-106684: Close
asyncio.StreamWriterwhenasyncio.StreamWriteris not closed by application (GH-107650) (GH-107656) #107836
Metadata
Metadata
Assignees
Labels
Projects
Status
Done