colorsys.rgb_to_hls(1, 1, 0.9999999999999999) raisesZeroDivisionError now (this probably is the ONLY case). Not sure if it's worth fixing, but I think "correct" in all cases is more important than "very slightly faster in theory".

This optimization is originally introduced in#23306, using the benchmark given in the PR, there's no observable performance regression with the extra check.

# /usr/bin/env pythonimporttimeitimportstatisticsfromLib.test.test_colorsysimportColorsysTestif__name__=='__main__':number=100repeat=100results=timeit.repeat('ColorsysTest().test_hls_roundtrip()',setup='from Lib.test.test_colorsys import ColorsysTest',number=number,repeat=repeat)running_times=list(sorted(results))mean=statistics.mean(running_times)std=statistics.stdev(running_times)print(f"Running time:{mean} ±{std} ms.  "f"(number, repeat) = ({number},{repeat})")

Another possible implementation is to do a try-except block for the division. Astry is almost no cost now, it would be theoretically faster than the current one. The return value would be different (a near white color can be represented in many forms in hls space). I prefer the current solution as it's easy to understand with the comment, but I do not oppose the other way.

• Issue:colorsys.rgb_to_hls raises ZeroDivisionError on nearly-white inputs #106498