Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
gh-105375: Improve _decimal error handling#105605
Merged
erlend-aasland merged 2 commits intopython:mainfromJun 11, 2023
Merged
gh-105375: Improve _decimal error handling#105605erlend-aasland merged 2 commits intopython:mainfrom
erlend-aasland merged 2 commits intopython:mainfrom
Conversation
Fix a bug where an exception could end up being overwritten.
18 tasks
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJun 9, 2023
Add proper error handling to add_errors_module() to prevent exceptionsfrom possibly being overwritten, and objects from being decref'ed twice.
sobolevn approved these changesJun 10, 2023
Contributor
miss-islington commentedJun 11, 2023
Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 11, 2023
Fix a bug where an exception could end up being overwritten.(cherry picked from commitc932f72)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 11, 2023
Fix a bug where an exception could end up being overwritten.(cherry picked from commitc932f72)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot commentedJun 11, 2023
GH-105647 is a backport of this pull request to the3.12 branch. |
bedevere-bot commentedJun 11, 2023
GH-105648 is a backport of this pull request to the3.11 branch. |
erlend-aasland added a commit that referenced this pull requestJun 11, 2023
erlend-aasland added a commit that referenced this pull requestJun 11, 2023
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix a bug where an exception could end up being overwritten.