Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105237: Allow callingissubclass(X, typing.Protocol) again#105239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commentedJun 2, 2023•
edited
Loading

@AlexWaygoodAlexWaygood changed the titlegh-105237: Allow callingissubclass(X, Protocol) againgh-105237: Allow callingissubclass(X, typing.Protocol) againJun 2, 2023
@AlexWaygood
Copy link
MemberAuthor

I've run the third-party tests we have attyping_extensions on a version of this PR. In combination with#105281, this causes no regressions.

@miss-islington
Copy link
Contributor

Thanks@AlexWaygood for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@AlexWaygood and@JelleZijlstra, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker cdfb201bfa35b7c50de5099c6d9078c806851d98 3.12

@JelleZijlstraJelleZijlstra added needs backport to 3.12only security fixes and removed needs backport to 3.12only security fixes labelsJun 5, 2023
@miss-islington
Copy link
Contributor

Thanks@AlexWaygood for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 5, 2023
…pythonGH-105239)(cherry picked from commitcdfb201)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-105316 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 5, 2023
@AlexWaygoodAlexWaygood deleted the protocol-subclass-regression branchJune 5, 2023 13:37
AlexWaygood added a commit that referenced this pull requestJun 5, 2023
GH-105239) (#105316)gh-105237: Allow calling `issubclass(X, typing.Protocol)` again (GH-105239)(cherry picked from commitcdfb201)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstraJelleZijlstra

Labels
stdlibPython modules in the Lib dirtopic-typingtype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@AlexWaygood@miss-islington@bedevere-bot@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp