Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Sync with importlib_metadata 6.5#103584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
edd7e34 to0da56a6Compare0da56a6 to89561ceCompareThe test failures illustrate that there are other classes in pip reliant on the lenience of Distribution not enforcing its abstractmethods and these issues weren't caught earlier because pip doesn't test against importlib_metadata. |
85d5bd3 to5a30cc3CompareI'll proceed to merge this change, but I'll be happy to entertain any review comments and will amend or roll back the changes as needed. |
bedevere-bot commentedApr 21, 2023
|
bedevere-bot commentedApr 21, 2023
|
bedevere-bot commentedApr 21, 2023
|
bedevere-bot commentedApr 21, 2023
|
I'm investigating these now. |
Failure message is: |
The tests are failing on Windows buildbots, but I struggle to think of what might be different about the buildbot environments that would affect this test. |
I'm also unsure how to replicate the failure. Tests clearly pass on Windows in general. What is it about this test that makes it fail in the buildbot environments only? Since I don't have a way to triage the failure further, I'm going to mark the test as "xfail" for now to stop the buildbot failures. |
…5.0 to version 6.6.0David Hotham (2): type annotations code reviewJason R. Coombs (9): Update compatibility for Python 3.12 (python/cpython#103584). Resolve the located directory and remove suppression of Exceptions. Refpython/cpython#103661. Wrap 'subdir/line' in PosixPath to ensure the output uses posix path separators. Refpython/cpython#103661. Update changelog Rename 'line' to 'name' for better context. Reword to prefer imperative voice and more a more concise description. Use generator expression for paths. Remove nitpick_ignore no longer needed. Update changelog
Uh oh!
There was an error while loading.Please reload this page.
Applies changes fromimportlib_metadata 5.1 through 6.5.0, including:
PackageMetadata.__getitem__returningNone(PackageMetadata.__getitem__ returns None importlib_metadata#371).MadeDistributionan Abstract Base Class (ABC) to honor the declaredabstractmethods (Abstract methods in non-abstract imporlib.metadata.Distribution importlib_metadata#419).Distributionnow warns when instantiated without its abstract methods being implemented (version 6.0.0 change of making Distribution an abstract class breaks some projects importlib_metadata#422).PackageMetadata.get_allto match the upstream implementation ofemail.message.Message.get_allinemail.message: Fix invalidTypeVarusage; add some default values typeshed#9620 (mypy failing importlib_metadata#434).packages_distributionsnow honors packages and modules with Python modules that not.pysources (e.g..pyc,.so) (Incompletepackages_distributionsimportlib_metadata#428).PackageMetadatanow stipulates an additionalgetmethod allowing for easy querying of metadata keys that may not be present (Should PackageMetadata.get be supported? importlib_metadata#384).installed-files.txtforDistribution.fileswhen present ("files" is wrong when installed without "wheel" importlib_metadata#115).