Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
Closed
Assignees
Description
Bug report
When debugging a test failure inhttps://pypi.org/project/fs/ I found a regression inzipfile, read1(-1) after seek() returns empty byte string instead of substring. I've bisected it into this commit330f1d5.
Reproducer:
import zipfile# First, create the zip:# echo 'Hello, World' > hello.txt# zip hello.zip hello.txtwith zipfile.ZipFile('hello.zip') as myzip: with myzip.open('hello.txt') as myfile: print(myfile.read(5)) print(myfile.seek(2, 1)) print(myfile.read1(-1))Expected output (3.11.2):
❯ python3.11 reproduce.pyb'Hello'7b'World\n'Actual output (3.12.0a6):
❯ python3.12 reproduce.pyb'Hello'7b''Your environment
- CPython versions tested on: main
- Operating system and architecture: Fedora 37, x86_64
Linked PRs
Metadata
Metadata
Assignees
Labels
Projects
Status
Done