Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Closed
Description
Reportedin discord, since#102018, the timing check was added totest_implied_dirs_performance and this check is frequently failing (example):
ERROR: test_implied_dirs_performance (test.test_zipfile.test_path.TestPath.test_implied_dirs_performance)----------------------------------------------------------------------Traceback (most recent call last): File "D:\a\cpython\cpython\Lib\contextlib.py", line 80, in inner with self._recreate_cm(): File "D:\a\cpython\cpython\Lib\test\test_zipfile\_context.py", line 30, in __exit__ raise DeadlineExceeded(duration, self.max_duration)test.test_zipfile._context.DeadlineExceeded: (3.140999999999849, 3)These failures aren't occurring onzipp, where the check has been running for years without fail.
Furthermore, the check is currently not capturing the failure case because the invocation fails to consume the generator:
| zipfile.CompleteDirs._implied_dirs(data) |
That indicates that the flaky failures are due to the construction of test data:
| data= ['/'.join(string.ascii_lowercase+str(n))forninrange(10000)] |