Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101865: Deprecateco_lnotab
from code objects as per PEP 626#101866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I've pushed my naive attempt to fix |
@markshannon friendly ping :) |
co_lnotab
from code objects as per PEP626co_lnotab
from code objects as per PEP626sobolevn commentedFeb 22, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Failures do not seem related 🤔 |
arhadthedev commentedFeb 25, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
@markshannon do you have time to re-review this, please? :) |
sobolevn commentedMar 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@carljm maybe you can have a look? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good in general.
We aren't obliged to removeco_lnotab
in 3.14, but we can. Perhaps change the "will"s to "may"s.
Not sure what to do aboutMisc/gdbinit
though.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here. |
@markshannon thanks a lot for your review and for all your hard work on CPython!
|
Shall we add a |
co_lnotab
from code objects as per PEP626co_lnotab
from code objects as per PEP 626sobolevn commentedMar 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think that we can add "is deprecated since 3.12 and may be removed in 3.14". |
Sure, let's do something like that. |
|
@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :) |
…26 (python#101866)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
…26 (python#101866)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Uh oh!
There was an error while loading.Please reload this page.
I still have to fix these lines:
cpython/Misc/gdbinit
Lines 60 to 61 in6ef6915
But, since I have 0 experience with
gdb
it might take some time.co_lnotab
must be removed in 3.12 according to PEP 626 #101865