Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101865: Deprecateco_lnotab from code objects as per PEP 626#101866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 10 commits intopython:mainfromsobolevn:issue-101865
Apr 3, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedFeb 13, 2023
edited by bedevere-bot
Loading

I still have to fix these lines:

cpython/Misc/gdbinit

Lines 60 to 61 in6ef6915

set $__sz = ((PyVarObject *)$__co->co_lnotab)->ob_size/2
set $__p = (unsigned char *)((PyBytesObject *)$__co->co_lnotab)->ob_sval

But, since I have 0 experience withgdb it might take some time.

@sobolevn
Copy link
MemberAuthor

I've pushed my naive attempt to fixgdb: since it only needs a current linef->f_lineno seems like a tool for the job. (again, this is my very first time working withgdb)

vasily-v-ryabov reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

@markshannon friendly ping :)

@sobolevnsobolevn changed the titlegh-101865: Remove deprecatedco_lnotab from code objects as per PEP626gh-101865: Deprecateco_lnotab from code objects as per PEP626Feb 21, 2023
@sobolevn
Copy link
MemberAuthor

sobolevn commentedFeb 22, 2023
edited
Loading

Failures do not seem related 🤔

@arhadthedev
Copy link
Member

arhadthedev commentedFeb 25, 2023
edited
Loading

test_implied_dirs_performance issue was fixed ingh-102225 so mergingmain should help.

sobolevn reacted with heart emoji

@sobolevn
Copy link
MemberAuthor

@markshannon do you have time to re-review this, please? :)

@sobolevn
Copy link
MemberAuthor

sobolevn commentedMar 18, 2023
edited
Loading

@carljm maybe you can have a look? :)

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good in general.
We aren't obliged to removeco_lnotab in 3.14, but we can. Perhaps change the "will"s to "may"s.

Not sure what to do aboutMisc/gdbinit though.

@markshannon
Copy link
Member

Perhaps we should discuss the future of Misc/gdbinit in another issue, and not worry about it here.

@sobolevn
Copy link
MemberAuthor

@markshannon thanks a lot for your review and for all your hard work on CPython!

  1. I've addressed all your comments
  2. I've opened a new issue aboutMisc/gdbinit:What to do withMisc/gdbinit? #102809

@hugovk
Copy link
Member

Shall we add a.. deprecated-removed: 3.12 3.14 in the main docs, somewhere nearhttps://docs.python.org/3.12/reference/datamodel.html?highlight=co_lnotab ?

@hugovkhugovk changed the titlegh-101865: Deprecateco_lnotab from code objects as per PEP626gh-101865: Deprecateco_lnotab from code objects as per PEP 626Mar 18, 2023
@sobolevn
Copy link
MemberAuthor

sobolevn commentedMar 19, 2023
edited
Loading

@hugovk
Copy link
Member

I think that we can add "is deprecated since 3.12 and may be removed in 3.14".

Sure, let's do something like that.

sobolevn reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

gdbinit was removed in#102854 🎉

@sobolevn
Copy link
MemberAuthor

@markshannon I've solved the merge conflicts. I hope that this is ready to be merged when you have the time :)

@ambvambv merged commit2a72125 intopython:mainApr 3, 2023
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull requestApr 8, 2023
…26 (python#101866)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
…26 (python#101866)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon left review comments

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sobolevn@arhadthedev@markshannon@hugovk@ambv@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp