A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

We're getting some test failures:

======================================================================[3683](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3684)ERROR: test_sequence_del_slice (test.test_capi.test_misc.CAPITest.test_sequence_del_slice)[3684](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3685)----------------------------------------------------------------------[3685](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3686)Traceback (most recent call last):[3686](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3687)  File "/Users/runner/work/cpython/cpython/Lib/test/test_capi/test_misc.py", line 459, in test_sequence_del_slice[3687](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3688)    _testcapi.sequence_del_slice(mapping, 1, 3)[3688](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3689)KeyError: slice(1, 3, None)[3689](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3690)[3690](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3691)======================================================================[3691](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3692)FAIL: test_sequence_set_slice (test.test_capi.test_misc.CAPITest.test_sequence_set_slice)[3692](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3693)----------------------------------------------------------------------[3693](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3694)Traceback (most recent call last):[3694](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3695)  File "/Users/runner/work/cpython/cpython/Lib/test/test_capi/test_misc.py", line 419, in test_sequence_set_slice[3695](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3696)    with self.assertRaises(TypeError):[3696](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3697)AssertionError: TypeError not raised[3697](https://github.com/python/cpython/actions/runs/4006251040/jobs/6877559173#step:7:3698)

It looks like the following test needs to be removed or changed as the expected behaviour would now be aKeyError as slice objects would now be valid as keys.

The following test can probably be modified to reflect the fact thatmapping[1:3] = 'xy' would be valid and that

mapping== {1:'a',2:'b',3:'c',slice(1,3,None):'xy'}

is true afterwards:

Please correct me if I am wrong, but it looks liketest_doctest() is failing because

@iritkatriel Apologies, but it looks like you were the last to modify this line. Does this sound about right to you?

EDIT: I think I've figured it out (below)!

@furkanonder

I think I understand now whytest_doctests() is failing.

On my system, if I clonemain, build it normally (non-debug), and computelen(tests) (see previous comment), I get843.

Now, if I clone your branch, build it normally (non-debug), I get844 instead. The extra entry totests is<DocTest builtins.slice.__hash__ from builtins:None (no examples)>, which isn't an element oftests onmain.

Now, running the tests (on your branch) with non-debug mode succeeds on my system.

Once we build with--with-pydebug, however, this adds an additional entry totests, namely,<DocTest builtins.set.test_c_api from builtins:None (no examples)> (whether on your branch ormain), making the number on your branch845, which makes

fail.

So, I think what needs to be done now is for you to modify that line intest_doctest.py, say, to

>>>830<len(tests)<850

I have verified thattest_doctests() passes after this change (both on non-debug and debug builds).

For reference:

>>>importbuiltins,doctest>>>tests=doctest.DocTestFinder().find(builtins)