NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-100739: Respect mock spec when checking for unsafe prefixes#100740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cjw296 merged 2 commits intopython:mainfromcklein:allow-spec

Jan 4, 2023

Merged

gh-100739: Respect mock spec when checking for unsafe prefixes#100740

cjw296 merged 2 commits intopython:mainfromcklein:allow-spec

Jan 4, 2023

Conversation

Copy link

Contributor

cklein commentedJan 4, 2023•
edited by AlexWaygood
Loading

Respect Mock spec for attribute names starting with assert (and typos)

Issue:Mock spec not respected for attributes prefixed with assert #100739

cklein requested a review fromcjw296 as acode owner

January 4, 2023 07:24

bedevere-bot added the awaiting review label

Jan 4, 2023

bedevere-bot mentioned this pull request

Jan 4, 2023

Mock spec not respected for attributes prefixed with assert#100739

Closed

Copy link

bedevere-bot commentedJan 4, 2023

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

cklein force-pushed theallow-spec branch fromde7a1ce to4f9dfefCompare

January 4, 2023 08:53

sobolevn reviewed

Jan 4, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-01-04-09-53-38.gh-issue-100740.-j5UjI.rst OutdatedShow resolvedHide resolved

Lib/test/test_unittest/testmock/testmock.pyShow resolvedHide resolved

cklein force-pushed theallow-spec branch frombbd3410 to3f201b1Compare

January 4, 2023 10:23

cklein requested review fromsobolevn and removed request forcjw296

January 4, 2023 10:24

sobolevn requested review fromcjw296 and removed request forsobolevn

January 4, 2023 10:28

carljm reviewed

Jan 4, 2023

View reviewed changes

Lib/test/test_unittest/testmock/testmock.pyShow resolvedHide resolved

ckleinand others added2 commits

January 4, 2023 21:45

Respect mock spec when checking for unsafe prefixes

3e2a2df

Update Misc/NEWS.d/next/Library/2023-01-04-09-53-38.gh-issue-100740.-…

f43a0f6

…j5UjI.rstCo-authored-by: Nikita Sobolev <mail@sobolevn.me>

cklein force-pushed theallow-spec branch from3f201b1 tof43a0f6Compare

January 4, 2023 20:46

Copy link

Member

carljm commentedJan 4, 2023

(Note, generally don't ever force-push to a PR, it disrupts incremental review. The commits will be squashed on merge anyway, so there's no harm in having the PR be a series of commits reflecting its development.)

carljm approved these changes

Jan 4, 2023

View reviewed changes

Copy link

Member

carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This LGTM, thanks for the fix!

bedevere-bot added awaiting core review and removed awaiting review labels

Jan 4, 2023

cjw296 approved these changes

Jan 4, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Jan 4, 2023

cjw296 merged commit7f1eefc intopython:main

Jan 4, 2023

bedevere-bot removed the awaiting merge label

Jan 4, 2023

AlexWaygood added needs backport to 3.10

only security fixes

needs backport to 3.11only security fixes labels

Jan 4, 2023

Copy link

Contributor

miss-islington commentedJan 4, 2023

Thanks@cklein for the PR, and@cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Copy link

Contributor

miss-islington commentedJan 4, 2023

Thanks@cklein for the PR, and@cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Copy link

bedevere-bot commentedJan 4, 2023

GH-100760 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Jan 4, 2023

Copy link

bedevere-bot commentedJan 4, 2023

GH-100761 is a backport of this pull request to the3.10 branch.

bedevere-bot removed the needs backport to 3.10only security fixes label

Jan 4, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 4, 2023

pythongh-100739: Respect mock spec when checking for unsafe prefixes (p…

9cbfcc8

…ythonGH-100740)(cherry picked from commit7f1eefc)Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 4, 2023

pythongh-100739: Respect mock spec when checking for unsafe prefixes (p…

f07d620

…ythonGH-100740)(cherry picked from commit7f1eefc)Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this pull request

Jan 4, 2023

gh-100739: Respect mock spec when checking for unsafe prefixes (GH-10…

541e7b8

…0740)(cherry picked from commit7f1eefc)Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this pull request

Jan 4, 2023

gh-100739: Respect mock spec when checking for unsafe prefixes (GH-10…

f49cc3c

…0740)(cherry picked from commit7f1eefc)Co-authored-by: Christian Klein <167265+cklein@users.noreply.github.com>Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

carljm added a commit to carljm/cpython that referenced this pull request

Jan 5, 2023

Merge branch 'main' into fieldrepr

60aa562

* main:pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753)pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702)  Drop myself from pathlib maintenance (python#100757)pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)