Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default Checking mergeability… Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:python/cpython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:encukou/cpython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:no-join-in-finalize-ever
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
Uh oh!
There was an error while loading.Please reload this page.
- 6commits
- 6files changed
- 1contributor
Commits on Feb 20, 2025
gh-87135: Raise PythonFinalizationError when joining a blocked daemon…
… threadIf `Py_IsFinalizing()` is true, non-daemon threads (other than the current one)are done, and daemon threads are prevented from running, so theycannot finalize themselves and become done. Joining them without timeoutwould block forever.Raise PythonFinalizationError instead of hanging.Seegh-123940 for a use case: calling `join()` from `__del__`. This isill-advised, but an exception should at least make it easier to diagnose.
Commits on Feb 27, 2025
- encukou committed
Feb 27, 2025 Raise for calls with timeout too
encukou committedFeb 27, 2025 - encukou committed
Feb 27, 2025 - encukou committed
Feb 27, 2025
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff main...no-join-in-finalize-ever
Uh oh!
There was an error while loading.Please reload this page.